Stories
Slash Boxes
Comments

Dev.SN ♥ developers

posted by martyb on Thursday November 27 2014, @09:24AM   Printer-friendly
from the static-page-vs-dynamic-page(?) dept.

An AC reported that they saw (parameterized here; replace text with corresponding character and remove all spaces):

underscore underscore SLASHLINK underscore underscore

when they viewed all comments on a story and/or tried to reply to a comment.

From an investigation of the code, it appears to be triggered by the setting of the slash var "article_link_story_dynamic" — on dev it's set to "1" but I cannot see its setting on production.

This post is an attempt to reproduce the problem.

The problem arises when a story includes a reference to another story on the site (if I understand correctly: the url contains a reference to article.pl)

So, here's a link to one: http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231 (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")

A quick review of (an old copy of) the code suggested the site var "article_link_story_dynamic" may be the culprit:

plugins/Relocate/Relocate.pm:                                next if $token->[1]{href} eq '__SLASHLINK__';
Slash/Utility/Data/Data.pm:                Slash/Utility/Data/Data.pm:                $retval = q{  
Slash/Utility/Data/Data.pm:HTML with slashized links (see slashizedLinks()) and converts them to
 
Slash/Utility/Data/Data.pm:                _slashlink_to_link($1, $options)
Slash/Utility/Data/Data.pm:sub _slashlink_to_link {
Slash/Utility/Data/Data.pm:# behavior of _slashlink_to_link.
 
Slash/Utility/Data/Data.pm:                # Set article_link_story_dynamic to 2 or greater and
Slash/Utility/Data/Data.pm:                my $force_dyn = $constants->{article_link_story_dynamic} > 1 ? 1 : 0;
Slash/Utility/Display/Display.pm:    my $dynamic = $constants->{article_link_story_dynamic} || $story_link->{dynamic} || 0;
sql/mysql/upgrades:6143:INSERT INTO vars (name, value, description) VALUES ("article_link_story_dynamic", "0", "Change default dynamic status for story linking");

Related Stories

Testing Factors for Character Entity and UTF-8 fixes 2 comments

Test factors for validating implementation of character entities and UTF-8 characters throughout SN.

These are the variables to permute:

  1. Characters under test: (cf: Trying some UTF-8 characters; POT, 0x0000 - 0x07ff POT, and 0x0800 - 0x0fff; POT)
    1. ampersand,
    2. less-than,
    3. greater-than,
    4. quote,
    5. Sampling of other named character entities,
    6. sampling of UTF-8 1-octet chars,
    7. sampling of UTF-8 2-octet chars,
    8. sampling of UTF-8 3-octet chars,
    9. sampling of UTF-8 4-octet chars (requires MySQL database update).
  2. Ordering of less-than and greater-than characters. (Slashcode has processing to strip HTML end elements which lack matching start elements.)
  3. Character representation:
    1. literal character,
    2. named character entity,
    3. decimal numeric character entity,
    4. hexadecimal numeric character entity.
  4. Text entry location (places where user input is obtained for later display):
    1. Story Submission (e.g. http://soylentnews.org/submit.pl):
      1. "Your Name",
      2. "Your Email or Homepage",
      3. "Title",
      4. "The Scoop",
    2. Editor's story processing (e.g. http://soylentnews.org/submit.pl?op=viewsub&subid=4848&title=Coal+Plants+Get+New+Lease+on+Life+with+Natural+Gas and then after Preview: (http://soylentnews.org/admin.pl) and then after approval, go in and edit the story again: (http://soylentnews.org/admin.pl?op=edit&sid=14/11/20/1556209.)
      1. "Dept" (e.g. from the hyphenated-words dept.),
      2. "Intro Copy" text area,
      3. "Extended Copy" text area,
      4. "Media" text area,
    3. Comment reply to a story (http://soylentnews.org/comments.pl?sid=4950&op=reply&threshold=-1&commentsort=0&mode=improvedthreaded#post_comment:
      1. "Subject",
      2. "Comment" text area
    4. Journal article submission: (http://soylentnews.org/my/journal and then click Write in Journal):
      1. "Subject",
      2. "Entry" text area,
    5. Journal Reply/Comment entry
      1. "Subject",
      2. "Comment"
    6. Poll creation (cf: http://soylentnews.org/pollBooth.pl) (Need help here; never submitted a poll before!)
      1. text(?),
      2. poll comment(?)
    7. Poll responses:
      1. "Subject" (??),
      2. "Comment" (??),
      3. Other (??)
    8. User preferences (http://soylentnews.org/my/info — "User" tab:
      1. "Real Name",
      2. "Email Address",
      3. "Homepage",
      4. "AIM",
      5. "ICQ UIN",
      6. "Yahoo! ID",
      7. "Jabber",
      8. "Public Calendar",
      9. "Mobile Text Address",
      10. "Sig" (120 chars),
      11. "Bio" (255 chars).
    9. Homepage - "User Space" text area (http://soylentnews.org/my/homepage) i.e. "If you choose 'User Space' above, the contents of this box will be inside:"
    10. Anything else?
  5. Story submission / comment submission format:
    1. "Plain Old Text",
    2. "HTML Formatted",
    3. "Extrans (html tags to text)",
    4. "code"
  6. Text viewing location:
    1. On-line web page,
    2. Print formatted story (printer icon) (e.g. http://soylentnews.org/print.pl?sid=14/11/20/1556209),
    3. e-mailed story,
    4. web message,
    5. RSS feed,
    6. Atom feed,
    7. "Authors page" (e.g. http://soylentnews.org/authors.pl),
    8. Author's Story list page (e.g. http://soylentnews.org/search.pl?op=stories&author=76),
    9. News Feed (NNTP) (How do we do this?),
    10. "Palm" (How do we do this?),
    11. Search results page (e.g. from using: http://soylentnews.org/search.pl).
    12. User's Info Page: (e.g. http://soylentnews.org/~martyb/),
      1. Comment list section as displayed here,
      2. Additional comments: next batch of comments and following,
      3. Recent Submissions section.
      4. PollBooth slashbox
      5. Poll Results (e.g. http://soylentnews.org/pollBooth.pl?qid=51&aid=-1
  7. Preview count: how many times a user has previewed a story submission or [journal|story] comment prior to submitting (preview has had some issues in the past.):
    1. Once,
    2. Twice,
    3. Thrice

If I have missed any user-visible input/output/modification location, please reply and let me know!

This discussion has been archived. No new comments can be posted.
Display Options Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
  • (Score: 2) by The Mighty Buzzard on Thursday November 27 2014, @09:31AM

    by The Mighty Buzzard (18) Subscriber Badge <themightybuzzard@soylentnews.org> on Thursday November 27 2014, @09:31AM (#28204) Journal

    I'm apparently not getting what the actual bug is. Slashlinks are a part of our system but users should never see them and I see no recipe to reproduce whatever this bug is.

    --
    123
    456
    789
  • (Score: 2) by martyb on Thursday November 27 2014, @09:34AM

    by martyb (76) on Thursday November 27 2014, @09:34AM (#28205) Journal
    Trying again (seems my prior problem was trying to post a comment to a story before it went live on the site!)

    In the above story, where it contains:

          So, here's a link to one: http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231 (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")</blockquote>

    When I do a view source (using Pale Moon 24.7.2 (x86)) on that text, I saw:

          So, here's a link to one: <a href="__SLASHLINK__" sect="mainpage" sid="14/11/20/1737231" sn="article" tid="5">http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231</a> (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")

    and, when I right clicked on that link and copied the link, it was captured as:

          http://dev.soylentnews.org/__SLASHLINK__

    So, I have been able to reproduce the problem, but my original idea as to the cause did not pan out. Hopefully, the included references in the original submission provide a starting point for where to look.
    • (Score: 2) by martyb on Thursday November 27 2014, @09:38AM

      by martyb (76) on Thursday November 27 2014, @09:38AM (#28206) Journal
      NOTE: This problem manifested when I tried to REPLY to the story, not when just viewing the page.
  • (Score: 2) by martyb on Thursday November 27 2014, @09:43AM

    by martyb (76) on Thursday November 27 2014, @09:43AM (#28208) Journal

    The motivation for all this was seeing this comment on the main site: http://soylentnews.org/comments.pl?sid=5039&cid=120451 [soylentnews.org]

  • (Score: 2) by The Mighty Buzzard on Monday December 22 2014, @12:07PM

    by The Mighty Buzzard (18) Subscriber Badge <themightybuzzard@soylentnews.org> on Monday December 22 2014, @12:07PM (#28209) Journal
    Fixed this in the moderation rework pull request.
    --
    123
    456
    789