Stories
Slash Boxes
Comments

Dev.SN ♥ developers

SLASHLINK bug - test story

posted by martyb on Thursday November 27 2014, @09:24AM   Printer-friendly
from the static-page-vs-dynamic-page(?) dept.

martyb writes:

An AC reported that they saw (parameterized here; replace text with corresponding character and remove all spaces):

underscore underscore SLASHLINK underscore underscore

when they viewed all comments on a story and/or tried to reply to a comment.

From an investigation of the code, it appears to be triggered by the setting of the slash var "article_link_story_dynamic" — on dev it's set to "1" but I cannot see its setting on production.

This post is an attempt to reproduce the problem.

The problem arises when a story includes a reference to another story on the site (if I understand correctly: the url contains a reference to article.pl)

So, here's a link to one: http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231 (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")

A quick review of (an old copy of) the code suggested the site var "article_link_story_dynamic" may be the culprit:

plugins/Relocate/Relocate.pm:                                next if $token->[1]{href} eq '__SLASHLINK__';
Slash/Utility/Data/Data.pm:                Slash/Utility/Data/Data.pm:                $retval = q{  
Slash/Utility/Data/Data.pm:HTML with slashized links (see slashizedLinks()) and converts them to
 
Slash/Utility/Data/Data.pm:                _slashlink_to_link($1, $options)
Slash/Utility/Data/Data.pm:sub _slashlink_to_link {
Slash/Utility/Data/Data.pm:# behavior of _slashlink_to_link.
 
Slash/Utility/Data/Data.pm:                # Set article_link_story_dynamic to 2 or greater and
Slash/Utility/Data/Data.pm:                my $force_dyn = $constants->{article_link_story_dynamic} > 1 ? 1 : 0;
Slash/Utility/Display/Display.pm:    my $dynamic = $constants->{article_link_story_dynamic} || $story_link->{dynamic} || 0;
sql/mysql/upgrades:6143:INSERT INTO vars (name, value, description) VALUES ("article_link_story_dynamic", "0", "Change default dynamic status for story linking");

 
This discussion has been archived. No new comments can be posted.
SLASHLINK bug - test story | Log In/Create an Account | Top | 1000 moderator points   | 6 comments | Search Discussion
Display Options Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.

  • (Score: 2) by martyb on Thursday November 27 2014, @09:34AM

    by martyb (76) on Thursday November 27 2014, @09:34AM (#28205) Journal
    Trying again (seems my prior problem was trying to post a comment to a story before it went live on the site!)

    In the above story, where it contains:

          So, here's a link to one: http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231 (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")</blockquote>

    When I do a view source (using Pale Moon 24.7.2 (x86)) on that text, I saw:

          So, here's a link to one: <a href="__SLASHLINK__" sect="mainpage" sid="14/11/20/1737231" sn="article" tid="5">http://dev.soylentnews.org/article.pl?sid=14/11/20/1737231</a> (which linked to the story: "Testing Factors for Character Entity and UTF-8 fixes")

    and, when I right clicked on that link and copied the link, it was captured as:

          http://dev.soylentnews.org/__SLASHLINK__

    So, I have been able to reproduce the problem, but my original idea as to the cause did not pan out. Hopefully, the included references in the original submission provide a starting point for where to look.
    Starting Score:    1  point
    Karma-Bonus Modifier   +1  
    Total Score:   2  

  • (Score: 2) by martyb on Thursday November 27 2014, @09:38AM

    by martyb (76) on Thursday November 27 2014, @09:38AM (#28206) Journal
    NOTE: This problem manifested when I tried to REPLY to the story, not when just viewing the page.