Stories
Slash Boxes
Comments

Dev.SN ♥ developers

Dev.SN is powered by your submissions, so send in your scoop. Only 6 submissions in the queue.

Log In

Log In

Create Account  |  Retrieve Password


Site News


Funding Goal
Base Goal: $3000
Progress So Far: $116
4%
Stretch Goal: $2,000
Progress So Far: $0
0%

Updated: 2017-01-14 --martyb


Support us: Subscribe Here


Buy SoylentNews Swag
We always have a place for talented people, visit the Get Involved section on the wiki to see how you can make SoylentNews better.

Poll

How many days are left before Christmas?

  • less than 20 but more than 10
  • 10 or fewer but more than 5
  • 5 or fewer

[ Results | Polls ]
Comments:3 | Votes:4

posted by martyb on Sunday February 19, @09:05PM   Printer-friendly

At the moment, no matter what Breakthrough/Threshold setting I choose, every Top Level Comment (TLC) is displayed fully expanded.

See: https://dev.soylentnews.org/article.pl?sid=17/02/16/0222248&threshold=5&highlightthresh=5&commentsort=0&mode=threadtos&page=1&noupdate=1#commentwrap

Consider what the "Deuteronomy child bride", "Penis Bird", and "Cheap Canadian V14gra" users would make of knowing that they can make sure that their TLC will always appear in full.

posted by martyb on Sunday February 19, @08:53PM   Printer-friendly

For the following "T:" denotes setting for Threshold and "B:" denotes a setting for Breakthrough.

Am I missing something or shouldn't: (T:-1, B:5) produce the same result as: (T:5, B:-1)

Under Threaded-TOS, I'm seeing different results on: https://dev.soylentnews.org/article.pl?sid=17/02/16/0222248 where the highest score for a comment is: 2.

T:-1, B:5 -- https://dev.soylentnews.org/article.pl?sid=17/02/16/0222248&threshold=-1&highlightthresh=5&commentsort=0&mode=threadtos&page=1&noupdate=1#commentwrap

T:5, B:-1 -- https://dev.soylentnews.org/article.pl?sid=17/02/16/0222248&threshold=5&highlightthresh=-1&commentsort=0&mode=threadtos&page=1&noupdate=1#commentwrap

Based on what I understand, T:-1, B:5 Says show me everything (scoring -1 or better) in full (oh, and boost visibility of those scoring 5 or better) -- but we are already selecting to show everything anyway

OTOH, T:5, B:-1 Says show me only those scoring 5 or better (there are none for that story), but boost all those scoring -1 or better, which is ALL of the comments, so it again selects to display everything.

posted by martyb on Thursday February 16, @11:13PM   Printer-friendly

It would be helpful for the user to have a label to explain what the seemingly barren "(1)" that appears in two places on a story actually means. Granted, on stories with enough comments, and that actually spills over onto additional pages, there is a bit more of an indication, but it could be made explicitly clear by adding just two lines to one template.

Extended copy has the updated version of the template. The two lines which contain only "Page:" are all it takes.

[% IF !((total < user.commentlimit) || (user.commentlimit < 1)) && (legacy == "yes") %]
        [% pages = total / user.commentlimit %]
        <div class="linkCommentPage">
        Page:
        [% FOREACH p = [1 .. pages] %]
                [% start = user.commentlimit * p %]
                [% IF p != 0 %] | [% END %]
                [% IF start == form.startat || (!form.startat && p == 0) %]
                        <b>([% p %])</b>
                [% ELSE %]
                        [% Slash.linkComment({
                                sid     => sid,
                                pid     => pid,
                                cid     => cid,
                threshold => threshold,
                highlightthresh = highlightthresh,
                                subject => p,
                                subject_only => 1,
                                startat => (start ? start : 0),
                        }) %]
                [% END %]
        [% END %]

        [% IF user.breaking %]
                ([% constants.sitename %] Overload: CommentLimit [% user.commentlimit %])
        [% END %]
        </div>
[% ELSIF (legacy == "no") %]
        <div class="linkCommentPage">
        Page:
    [% form.page = (form.page || 1) %]
    [% FOREACH p = [1 .. tpages] %]
        [% IF p != form.page %]
            [% Slash.linkComment({
                sid    => sid,
                pid    => pid,
                cid    => cid,
                threshold => threshold,
                                highlightthresh = highlightthresh,
                subject => (p),
                                subject_only => 1,
                page    => (p),
            }) %]
        [% ELSE %]
            <b>([% p %])</b>
        [% END %]
    [% END %]
    </div>
[% END %]

posted by martyb on Thursday February 16, @10:58PM   Printer-friendly
from the tell-us-what-you-think dept.

For those who came here from our Third Anniversary Story... Welcome!

This story is for you. Feel free to play around with the new features, post comments, and moderate to your heart's content. If you find anything amiss or wish to discuss a feature or provide feedback, please comment here and/or leave a comment on the #dev channel on IRC.

posted by martyb on Wednesday February 15, @10:14PM   Printer-friendly

20170215e - Test Story - Please DO NOT Moderate and DO NOT Post Comments - Comment Score Testing

The comment structure AND the comment scores have been carefully crafted - please do not touch. --martyb

There is one top-level comment (TLC); it has score: -1
That TLC has 4 children, respectively scored: -1, 0, 1, and 2.
EACH of those children has 4 children, respectively scored: -1, 0, 1, and 2.

-1     -1      -1
                0
                1
                2

        0      -1
                0
                1
                2

        1      -1
                0
                1
                2

        2      -1
                0
                1
                2

posted by paulej72 on Wednesday February 15, @10:12PM   Printer-friendly
Getting hash instead of preview. Are we not using the hard coded generation? Do we need to keep the templates so this works?
posted by martyb on Wednesday February 15, @05:03PM   Printer-friendly

Have a few issues with the new "[Continues...]" item which is automatically added to stories that have a non-empty "Extended Copy" section.

1) When editing a story, the "[Continues...]" text does not appear when I click on the "Preview" button.

2) Accidentally discovered it is implemented as a link, not just plain text, when I somehow clicked on it on the main page and saw the extended copy text suddenly appear... this is confusing. It looks exactly like the text we editors previously inserted into stories manually, but has a different effect -- need to visually distinguish it from the old-style, text-only version (e.g. one couldunderline the link but see next item).

3) Once I click on the "[Continues...]" link on the main page and see the expanded text, I see no way to re-collapse it. :(

4) May I suggest reusing the "Expand/Collapse comment" single-chevron that is employed in the new threaded comment code?

5) For completeness' sake, the prior 4 items were in the "Intro Copy" text box, and this item is at the top of the "Extended Copy" text box.

posted by The Mighty Buzzard on Wednesday February 15, @03:23PM   Printer-friendly
Need user-preference for dimming/badge. Need badge graphic. Need code/css reworked to put the appropriate one into the page.
posted by The Mighty Buzzard on Wednesday February 15, @03:18PM   Printer-friendly
Behaving how I wrote it to but not accurately reflecting Threaded on Live.
posted by The Mighty Buzzard on Wednesday February 15, @03:15PM   Printer-friendly
Page 2 on https://dev.soylentnews.org/comments.pl?noupdate=1&sid=1344&mode=threadtng&page=2 does not properly collapse comments.